[claude] Consume hai-agents SDK local mode; drop owned binary lifecycle#3
Draft
cm2435-hcomp wants to merge 9 commits into
Draft
[claude] Consume hai-agents SDK local mode; drop owned binary lifecycle#3cm2435-hcomp wants to merge 9 commits into
cm2435-hcomp wants to merge 9 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
HoloDesktop stops owning the runtime binary lifecycle and consumes
hai-agents[local]instead (plan 003 ofeng_plans/30-06-2026-agent-api-local-runtime). Net −1,353 LoC (1,500 added, 2,853 deleted).sdk_runtime.py,inherit_env=False, keeps the self-hostedHAI_API_KEYstrip), aSessionApiadapter overAsyncClient.local/AsyncSessionHandle, and re-homes macOS TCC first-run detection to read the SDK'sruntime.log_path(permissions.py).holo stop --forceuses SDK cross-process discovery + a one-release legacy~/.holo/agent-pid-<port>read;holo doctor/agent-apireport SDK runtime state.Why
One shared, tested binary lifecycle in the SDK instead of a HoloDesktop-private copy. HoloDesktop keeps everything product-shaped.
How — what stays byte-identical (verified 0-line diff vs baseline)
requests.py(Holo request/profile construction),session_runner.py, and the entirekillswitch/package (~/.holo/stopdouble-Esc → pause-then-cancel) are unchanged — only the HTTP calls behind them moved to SDK handles. The session-runner swap was gated by a fake-mode integration test before and after.Validation
mypyclean (47 files)⛔ SHIP-GATE
pyproject.tomlpinshai-agentsvia a dev[tool.uv.sources]path override to the local SDK mirror (marked# SHIP-GATE). Replace with the publishedhai-agents[local]version — plan 002 must publish first.Owner live-smoke checklist (your terminal — TCC/desktop, not an agent context)
uv run holo doctor— all green, agent-api reports SDK runtime stateuv run holo run --fake --no-kill-switch "say hi"— exit 0uv run holo run "open calculator"— opens + answer panel; retry with double-Esc →✗ interruptedholo serve+holo stop --force(two terminals) →force-killed runtime pid(s) …~/.holo/.first-run-complete, run, confirm panel + one auto-restart + marker)Notes
Known-stale (deliberate, left for follow-up to preserve the "no killswitch diff" rule):
killswitch/__init__.pydocstring still names the old launcher path. Stack: depends on plan 002 being published; landing order per the master README.🤖 Generated with Claude Code